Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile benchmarks as separate modules and fix broken compilations of executable files #44

Merged
merged 3 commits into from
Dec 14, 2024
Merged

Compile benchmarks as separate modules and fix broken compilations of executable files #44

merged 3 commits into from
Dec 14, 2024

Conversation

CihatAltiparmak
Copy link
Member

In this PR, i rearranged directories of benchmark modules. You can see what i changed in below. Additionaly, google benchmark is not compatible when our benchmarks is compiled using common shared lib. This is corresponding issue: google/benchmark#1498

FROM :

.
├── CMakeLists.txt
├── include
│   └── moveit_middleware_benchmark
│       └── scenarios
│           ├── scenario_basic_service_client.hpp
│           └── scenario_perception_pipeline.hpp
└── src
    ├── scenario_basic_service_client_benchmark_main.cpp
    ├── scenario_perception_pipeline_benchmark_main.cpp
    └── scenarios
        ├── scenario_basic_service_client.cpp
        └── scenario_perception_pipeline.cpp

15 directories, 27 files

TO :

.
├── CMakeLists.txt
├── include
│   └── moveit_middleware_benchmark
│       ├── scenario_basic_service_client
│       │   └── scenario_basic_service_client.hpp
│       └── scenario_perception_pipeline
│           └── scenario_perception_pipeline.hpp
└── src
    ├── scenario_basic_service_client
    │   ├── CMakeLists.txt
    │   ├── scenario_basic_service_client_benchmark_main.cpp
    │   └── scenario_basic_service_client.cpp
    └── scenario_perception_pipeline
        ├── CMakeLists.txt
        ├── scenario_perception_pipeline_benchmark_main.cpp
        └── scenario_perception_pipeline.cpp

17 directories, 29 files

@CihatAltiparmak
Copy link
Member Author

CihatAltiparmak commented Dec 9, 2024 •
edited
Loading

Hi @sjahr , i am pinging you for a review because seems you are only one who can review this PR. If you are willingness to take a look, please take a look, if not, you are free to just click on approve button. Thanks in advance. Btw, CI fails because i have forgotten to give credentials to pull docker image and package is in private. Don't mind. I will fix it in other PRs.

@CihatAltiparmak CihatAltiparmak requested a review from sjahr December 9, 2024 17:37
sjahr
sjahr approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good + makes sense. Thanks!

@CihatAltiparmak
Copy link
Member Author

Heartfelt thank you for your interest

@CihatAltiparmak CihatAltiparmak merged commit 60d8748 into main Dec 14, 2024
5 of 6 checks passed
@CihatAltiparmak CihatAltiparmak deleted the fix/compile_benchmarks_as_separate_modules branch December 14, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjahr sjahr sjahr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CihatAltiparmak @sjahr